RTC plugin fixes and extension

troglobit / finit

Fast init for Linux. Cookies included

https://troglobit.com/projects/finit/

MIT License

634 stars 64 forks source link

RTC plugin fixes and extension #419

Closed troglobit closed 3 weeks ago

troglobit commented 3 weeks ago

This PR contains three major changes to the RTC plugin:

Big refactor for readability, breaking out time_set() and time_get() functions
Add support for saving and restoring time from a file on systems with seriously buggy RTC
Fix --with-rtc-date fixes, both configure script and strpdate() error handling

troglobit commented 3 weeks ago

@wkz could you have a look at the second commit in this PR? It should fix issue kernelkit/infix#794 -- I have tested it on an x86_64 qemu system where I disabled the RTC driver, and it works great. We should test it also on aarch64, of course, but it needs a few tweaks to the finit.mk in Infix first.

troglobit commented 3 weeks ago

This looks great! 💪

Thanks! :smiley:

If the time we read from the RTC is invalid, then we could use the file data as a fallback. This would improve the worst-case date offset for a device that has been gathering dust for a year, and whose super-cap has long since been drained.

Interesting idea! And, like you say, combined --with-rtc-date, it should improve the situation radically! I'll have a look!

troglobit commented 3 weeks ago

Alright, now it looks as follows if both RTC is bad and the system has no "save game" on disk yet:

● ● ●  Infix -- a Network Operating System v24.10.1-68-ge50fa66b ═══════
[ OK ] Mounting filesystems from /etc/fstab
[WARN] Restoring system clock (UTC) from RTC
[WARN] Restoring system clock from backup

... and when we have a bad RTC and working backup:

[WARN] Restoring system clock (UTC) from RTC
[ OK ] Restoring system clock from backup