We're still cleaning up the mDNS source code according to findings of the clang-tidy-9 static checker. This time we're removing narrowing conversions, unneeded casts, and an unsafe string->int conversion.
Integer types are still being handled in a sloppy way in some places, e. g. by storing a size_t in an int, which may not necessarily fit. I added casts in a few places which both silence the static checker and point out the possible overruns. In completely clean code, most of these casts should not be necessary. No functional changes were introduced.
Also, a vim swap file was committed by accident. May well have been me in a previous commit, sorry :-/ Removed it and added *.swp to the git ignore file.
troglobit
commented
4 years ago
We're still cleaning up the mDNS source code according to findings of the clang-tidy-9 static checker. This time we're removing narrowing conversions, unneeded casts, and an unsafe string->int conversion.
Integer types are still being handled in a sloppy way in some places, e. g. by storing a size_t in an int, which may not necessarily fit. I added casts in a few places which both silence the static checker and point out the possible overruns. In completely clean code, most of these casts should not be necessary. No functional changes were introduced.
Also, a vim swap file was committed by accident. May well have been me in a previous commit, sorry :-/ Removed it and added *.swp to the git ignore file.