search

troglobit / mdnsd

Jeremie Miller's original mdnsd
BSD 3-Clause "New" or "Revised" License
57 stars 35 forks source link

Fix check for conflict in mdnsd_in #55

Closed fzs closed 2 years ago

fzs commented 2 years ago

To be honest, I do not really understand what this code does, or rather what it is used for. But it still looks like an error to me, when a for loop runs over the count of authority responses but then walks over the array of answers. Since I guess that we are actually interested in the answers here, I suggest that the for loop boundary is changed to the count of answer responses.

Since this is code from the original import, it looks like this functionality never worked (no NS records) or only by chance.

troglobit commented 2 years ago

Very likely a cut-and-paste bug from the original author.

Also, sorry for missing these PRs. Never got any notification of them.