search

troglobit / mdnsd

Jeremie Miller's original mdnsd
BSD 3-Clause "New" or "Revised" License
55 stars 35 forks source link

Read AAAA records #57

Closed fzs closed 1 year ago

fzs commented 1 year ago

This is a first step into the IPv6 direction, relating to #10, just to see if the direction is right. This enabled querying for AAAA records and receiving responses. The PR is in draft mode, because I would like to get PR #56 reviewed and merged first, since this one has a slight overlap.

fzs commented 1 year ago

@troglobit , can you enable running workflows?

troglobit commented 1 year ago

Looks good so far, to me at least :)

Appreciate very much the clean code and adherence to coding style! <3

fzs commented 1 year ago

I have rebased the branch on top of the current master.

Yeah, I try my best to adhere to existing coding style that I see in a file. I might not really agree a 100% with all the Linux kernel rules. But you can always let me know should I deviate too much somewhere.

I don't know how much time you have to spare for this project, but your reviews and any comments you have are very welcome, as I do not have too deep familiarity with it. I am just now reworking adaption and integration a bit.

troglobit commented 1 year ago

Now that notifications work properly I'll try to give as much feedback as possible. Thank you for taking the time to communicate and contribute to the project! <3