troglobit / mrouted

The original DVMRP (dynamic multicast routing) implementation for UNIX
https://troglobit.com/projects/mrouted/
Other
83 stars 17 forks source link

mrouted 4.0 reports "warning - Cannot disable multicast routing in kernel: Permission denied" when starting #35

Closed F-i-f closed 4 years ago

F-i-f commented 4 years ago

System: mrouted 4.0 linux kernel 5.5.17 Fedora 31

Every time mrouted starts, it reports:

mrouted[242850]: warning - Cannot disable multicast routing in kernel: Permission denied

Otherwise it seems to be working properly.

troglobit commented 4 years ago

Weird, that warning comes from k_stop_dvmrp() which is only called on SIGHUP and when shutting down mrouted? Is it possible that you're seeing mrouted restart or something like that?

Anyway, the root cause turned out to be in the cleanup() function which called k_stop_dvmrp() twice. I'll post a fix in a minute to address this, which I believe fixes what you are seeing.

Thank you for taking the time to report this! <3

F-i-f commented 4 years ago

Confirmed that 50b24f7 takes care of the problem.

troglobit commented 4 years ago

Awesome, thank you for verifying!