search

troglobit / pimd

PIM-SM/SSM multicast routing for UNIX and Linux
http://troglobit.com/projects/pimd/
BSD 3-Clause "New" or "Revised" License
194 stars 86 forks source link

igmp query interval fixes, disable-vifs config fix #102

Closed jp-t closed 7 years ago

jp-t commented 7 years ago
  1. the config file fix allows enabling interfaces after a disable-vif config command
  2. The group membership timeout fix allows setting a query interval larger than the default constant. Otherwise, local group memberships time out before the querier can refresh them.
  3. In any case the default query interval 12 is wrong, probably truncated from 125, and caused 2) to happen frequently.
troglobit commented 7 years ago

Great work, as usual! :-)

For future reference, it's a good idea to do separate pull requests for separate fixes. Much like separate commits for separate fixes. Hence, f9e11be and 60f9ecf should preferably have been in a separate pull request.

Also, if you prefix the first line of the commit message with "Fix #100: ...", when I approve the pull request, issue #100 is automatically closed! :)

jp-t commented 7 years ago

Great, thanks for the advices! I was not too sure if you'd like your repo clobbered with "merge pull request" commits ...especially for such one-line commits or so :-)

troglobit commented 7 years ago

No problem :)

Ah, the question of GIT and "merge commits". A couple of years ago I was actually very much against such clobbering, but the more I've started working with feature branches and GIT, the more I'm starting to appreciate them. I don't even to git rebase on my feature branches ... :)