search

troglobit / pimd

PIM-SM/SSM multicast routing for UNIX and Linux
http://troglobit.com/projects/pimd/
BSD 3-Clause "New" or "Revised" License
194 stars 86 forks source link

Post pimd restart ipc hung fix #151

Closed Valrast closed 4 years ago

Valrast commented 4 years ago

After restart happens(kill HUP/pimctl restart), nhandlers is set to 0. That brakes ICP communication with pimctl. Reset should clear and reinitialize icp.

troglobit commented 4 years ago

Good catch! Would you mind redoing the patch to match the guidelines for the project?

https://github.com/troglobit/pimd/blob/master/docs/CONTRIBUTING.md

I'm thinking about both coding style and the commit message; 1) "Update main.c" is not very descriptive, I can see from the diff that the change affects main.c, but I want to know why as early as possible. 2) The indentation does not match the code surrounding your change.

troglobit commented 4 years ago

Thank you for your contribution!

I took the liberty of fixing up a) the remaining indentation issue, and b) squash all your commits to one before I merged to master. Log history/readability matters to me as a maintainer, and also other in many other projects.