search

troglobit / pimd

PIM-SM/SSM multicast routing for UNIX and Linux
http://troglobit.com/projects/pimd/
BSD 3-Clause "New" or "Revised" License
198 stars 90 forks source link

fix: /24 group address format for pimctl #229

Closed stormshield-sylvainm closed 2 years ago

stormshield-sylvainm commented 2 years ago

This commit fix error in function netname. In case of 224.1.1.0/24, the output string was 224.1.1 because in forgemask the return value is always class C. We have fix it and we have remove the compact notation because it's less clear.

stormshield-sylvainm commented 2 years ago

gcc failed because 

R2 <-> R4                                                                   
ping: connect: Network is unreachable
...

I think this a random error This error has happened before : https://github.com/troglobit/pimd/runs/6261288798?check_suite_focus=true

troglobit commented 2 years ago

Yeah the test is a bit unstable, I think it's because the OSPF routers sometimes fail to peer in time, for some reason.

I was just thinking about this change. The original authors had some wonky ideas about things, and this "shortened" network name is one such thing that I think actually originates from mrouted. Anyway, I think your reasoning is sound, no need to continue using this shortened format any longer.