search

troglobit / pimd

PIM-SM/SSM multicast routing for UNIX and Linux
http://troglobit.com/projects/pimd/
BSD 3-Clause "New" or "Revised" License
200 stars 90 forks source link

PIM Assert state correction #64

Closed idismmxiv closed 8 years ago

idismmxiv commented 8 years ago

Proposal for assert state handling fixes to issue #63. It might be the case that MRTF_ASSERTED flag was meant to be used for inbound ASSERT detection only, but I took it into outbound handling as well. Had to add check for mrt->upstream pointer as well, as it was fairly easy to get pimd to crash without that.

With these changes ASSERT state is cleared after 180 seconds (hard coded value). Is this the "right" fix; I am not sure.

troglobit commented 8 years ago

I think this looks great! Very clean patch indeed. Will give it a spin ASAP in my testbed to see if it breaks something obvious.

troglobit commented 8 years ago

@idismmxiv As you know, I usually like to credit people who make significant contributions. Would you care to reveal your first and last name, or remain under this anonymous guise? :smiley:

idismmxiv commented 8 years ago

We are redefining our contribution policy at work at the moment. Looks like after couple of days (next week perhaps) we have clearer guidance how to do open source contributions. So I hope you bare with Idis few more days.

troglobit commented 8 years ago

@idismmxiv No problem, I'll just delay the release a while longer! (Which is not a problem anway, still waiting for confirmation of having fixed issue #57 for FreeBSD :)

idismmxiv commented 8 years ago

Added one more commit as there was unnecessary comparison in the case where new MRT entry was not created at all. Regarding our contribution policy, it will still take little while (days, few weeks, who knows). If @troglobit want to move forward and release next version, then you are free to leave this contribution as anonymous.

troglobit commented 8 years ago

Thank you!

I'm in no hurry to release anything yet. The FreeBSD problems we've seen turned out to be simple misconfiguration, and there are a few more issues I'd like to fix before releasing v2.3.2 anyway :)

troglobit commented 8 years ago

@idismmxiv Any news on your company's open source policy? Due to the latest PR I'd like to get v2.3.2 released soon, like end of Febuary if possible.

idismmxiv commented 8 years ago

I made proposed code cleanup and added signed-off-by line to commit.

troglobit commented 8 years ago

Alright, great! Hi Mika :smiley:

I'll rebase and merge later this week, thank you!

troglobit commented 8 years ago

Merged to master, with only slight (whitespace) changes.