troglobit / smcroute

Static multicast routing for UNIX
https://troglobit.com/projects/smcroute/
GNU General Public License v2.0
244 stars 64 forks source link

Fails to build when git is not available #176

Closed bombadil closed 3 years ago

bombadil commented 3 years ago

The released tar archive https://github.com/troglobit/smcroute/releases/download/2.5.4/smcroute-2.5.4.tar.gz doesn't build anymore when Git is not installed in the build environment:

sh: 1: git: not found
configure.ac:9: error: AC_INIT should be called with package and version arguments
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:9: the top level
autom4te: error: /usr/bin/m4 failed with exit status: 1
aclocal: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: error: aclocal failed with exit status: 1
dh_autoreconf: error: autoreconf -f -i returned exit code 1

The build logs logs can be found here: https://salsa.debian.org/debian/smcroute/-/jobs/2183105 and even the full source directory is available here for further investigation: https://salsa.debian.org/debian/smcroute/-/jobs/2183105/artifacts/browse/debian/output/ (see folder source_dir).

I didn't look into further details yet, but I wanted to let you know early.

Cheers

troglobit commented 3 years ago

Ouch, forgot about the dh_autoreconf step in Debian! :-/

Thanks for letting me know, I'll revert that change in a61969d and go back to stepping the version manually. Terribly sorry about this!

troglobit commented 3 years ago

Reverted in 4302689, prepared for another patch release. However, I'd recommend going for v2.5.3 + backport of these patches, since I won't be able to make another release for a few days:

Again, sorry about the mess! :-/

troglobit commented 3 years ago

FYI: We just had another minor fix go in this morning, so I'll start the release process and will hopefully get a 2.5.5 out by the end of the week.

bombadil commented 3 years ago

If it is just a matter of days, no need to rush anything. I'll just wait for 2.5.5 to be released then.

troglobit commented 2 years ago

There, v2.5.5 release available now.