troglobit / smcroute

Static multicast routing for UNIX
https://troglobit.com/projects/smcroute/
GNU General Public License v2.0
244 stars 64 forks source link

Do not hide the build commands by default #6

Closed bombadil closed 10 years ago

bombadil commented 10 years ago

For security reviews long time after build it is sometimes essential to be able to tell from the build logs what compiler flags were really used to build the binary. To support such reviews, the build commands should not be hidden by default.

I intend to work on this issue in the next week, but not today.

troglobit commented 10 years ago

For Inadyn I've had make V=1 to disable @ in front of $(CC), but you say "not be hidden by default"? What security standard or praxis are you referring to, Debian?

troglobit commented 10 years ago

So ... I've converted to use automake. Default is silent rules disabled, --enable-silent-rules to configure enables them, like in other projects, or V=0 if disabled. So your use-case should now be covered.

I've tested both make install and make dist, and all files seem to tag along. Even tried it all out successfully on my FreeBSD box.

Feel free to reopen the issue if you feel this commit isn't sufficient.

bombadil commented 10 years ago

Thanks a lot, I was not referring to a particular security standard or praxis. I just know it from my own experience how annoying it can be to not see the used compiler flags in archived build logs.

Your switch to automake solved my issue just perfectly. Thanks for doing it that incredibly fast - I couldn't have done it that fast...

Best regards, Micha

troglobit commented 10 years ago

OK, thanks for clarifying. Was just curious if there was anything I could read up on.

Glad to help. Will try to get a 2.0 release out this week :+1: