search

troibe / material-components-web-miso

Matiso - Material components for Miso
https://www.matiso.dev
7 stars 0 forks source link

Fix switch #12

Closed troibe closed 3 years ago

troibe commented 3 years ago

Why: Up to this point the switch on the demo page was not working #6

What: Added the switch status to the model

Testing: Before After
Fix-Switch-before Fix-Switch-after

The slow response time should only be due to lots of other programs running in the background.

adrianomelo commented 3 years ago

I actually added the review of the Snackbar into this PR.

Thanks for inviting me to be an admin of the project. :+1:

I believe some of the open pull requests are independent. I suggest creating PRs with the isolated commits to make it easier to review.

troibe commented 3 years ago

Thanks for the reviews! I'm always happy to learn and improve my Haskell skills. Since I was working with a rebase workflow in my last internship instead of the more traditional merge workflow I stacked the pull requests. For normal git usage you would create independent pull requests and solve merge conflicts after the fact right? In this case the only conflicts occurring would be on Main.hs...

adrianomelo commented 3 years ago

For normal git usage you would create independent pull requests and solve merge conflicts after the fact right?

Yes, the way I usually do is keeping different branches with independent changes. You probably won't have conflicts or they should be easy to fix in this case. As you said, the only common file is Main.hs, and, for most of the PRs, you are only adding lines.

It is tricky when you have so many pull requests, but in this case, It would be better to combine multiple components instead of having the same commits on multiple pull requests. (from my point of view)