search

troibe / material-components-web-miso

Matiso - Material components for Miso
https://www.matiso.dev
7 stars 0 forks source link

Add Menu #23

Closed troibe closed 3 years ago

troibe commented 3 years ago

Why:

Menu is part of the official material design components

What:

Added Menu

Testing:

Before After
grafik menu

Note: Removed TabBar due to crashes

troibe commented 3 years ago

I noticed that when there is no ListItem action we will get some crashes as you noted in your implementation. However I also didn't find a quick fix for it unfortunately so just put some dummy actions.

adrianomelo commented 3 years ago

I noticed that when there is no ListItem action we will get some crashes as you noted in your implementation. However I also didn't find a quick fix for it unfortunately so just put some dummy actions.

Yeah, I couldn't find a solution for it. My understanding is that the decoder should "fail" somehow to be compatible with the original Elm implementation, however, I am not sure if the decoder can "fail".