search

troibe / material-components-web-miso

Matiso - Material components for Miso
https://www.matiso.dev
7 stars 0 forks source link

Introduce select #4

Closed adrianomelo closed 3 years ago

adrianomelo commented 4 years ago

Why:

Select is part of the original Elm library.

What:

Introducing the Select component without:

Testing:

https://user-images.githubusercontent.com/329541/103247081-ee17e500-4965-11eb-9a45-9a3b7e345742.mp4

troibe commented 4 years ago

Wow great! :heart: Upon first inspection it looks good. I will later/tomorrow pull it and try it out myself. Once you feel ready could you split it up in three commits? :thinking:

  1. Creating list
  2. Creating menu
  3. Creating select

Since you did a lot more work than just creating select! :tada: Especially lists are super important! :+1:

Yes the javascript might have been outdated since I used the one from the material-components-web-miso at that point in time. Maybe with this new version the other open issue gets fixed as well. Let's see... It might be worth documenting the current version of the javascript either in the file itself or in the corresponding commit message.

Also since we don't have any tests currently could you add images or videos to the pull request for the UI changes once you are done?

adrianomelo commented 3 years ago

Thanks!

I am going to break the PR into several PRs then. It should make it easier for you to review and for me to have a more manageable set of changes.