Migrate to ML Kit for scanning QR code

trojan-gfw / igniter

A trojan client for Android (UNDER CONSTRUCTION).

GNU General Public License v3.0

3.3k stars 736 forks source link

Migrate to ML Kit for scanning QR code #313

Closed TchaikovDriver closed 4 years ago

TchaikovDriver commented 4 years ago

Import CameraX for image analysis.
Migrate from bingoogolapple/BGAQRCode-Android to ML Kit for QR code scanning.

wongsyrone commented 4 years ago

Thanks for the PR. I don't understand why the CameraX library is Kotlin-only. Do you have any references for it?

Some refs:

https://developer.android.com/jetpack/androidx/releases/camera#dependencies https://developer.android.com/training/camerax/configuration#java https://developers.google.com/ml-kit/vision/barcode-scanning/android#java

TchaikovDriver commented 4 years ago

Thanks for the PR. I don't understand why the CameraX library is Kotlin-only. Do you have any references for it?

Some refs:

https://developer.android.com/jetpack/androidx/releases/camera#dependencies https://developer.android.com/training/camerax/configuration#java https://developers.google.com/ml-kit/vision/barcode-scanning/android#java

Sorry for confusing you, I saw the start tutorial of CameraX which mentions adding apply plugin: 'kotlin-android-extensions' at the top of the file build.gradle. Then I considered that CameraX requires kotlin support. In fact, CameraX is not Kotlin-only, since Kotlin is compatible to Java.

wongsyrone commented 4 years ago

@TchaikovDriver Do you have any plan to rewrite it in Java?

TchaikovDriver commented 4 years ago

@TchaikovDriver Do you have any plan to rewrite it in Java?

That's easy, but just a bit later, will make a commit in these days.

TchaikovDriver commented 4 years ago

@wongsyrone Done

wongsyrone commented 4 years ago

LGTM. Thanks for the PR.