search

trojsten / submit

Other
1 stars 0 forks source link

Fix relative imports don't work this way in Python 3 #22

Closed black3r closed 7 years ago

black3r commented 7 years ago

toto bola jedina drobnost, ktoru som nasiel, co na python 3 nefungovala (although testy by sa zisli na potvrdenie)

closes #17

maaario commented 7 years ago

Nie je problem s nejakymy volaniami predkov cez super()? Napr. v https://github.com/trojsten/submit/blob/master/submit/forms.py

Ako si zistoval ci to funguje? Proste si to spustil s py 3 a preklikal si si ?

black3r commented 7 years ago

super, ako ho poznas z python2 funguje normalne v python3, python3 akurat pridal moznost volat super bez argumentov.., skor som cakal ze bude problem s konverziou medzi bytes a unicode stringami, ale asi vdaka tomu, ze to medzitym saveujes do suboru, tak tam nenarazas na tie problemy, co sme mali v starej submit appke :D

a jj spustil som s python 3.5 a preklikal..,

maaario commented 7 years ago

Problem s konverziou naozaj je: nefunguje submitovanie kodu.

Vo funkcii judge_helpers.py in prepare_raw_file sa funkciou submit_helpers.py in write_chunks_to_file zapisuje hlavicka raw suboru a kod ... kod sa precita zo suboru otvoreneho ako 'rb' ale hlavicka nie: bytes-like object is required, not 'str'

A takisto asi bude problem pri zobrazovani kodu v submite, kde sa pouziva str.decode().