trolie / spec

Transmission Ratings and Operating Limits Information Exchange
https://trolie.energy/
Other
2 stars 2 forks source link

Forecasting docs enhancements #83

Closed catkins-miso closed 3 months ago

catkins-miso commented 3 months ago

The primary updates are:

caindy commented 3 months ago

As usual, you're a fantastic writer. But yes, I do have some requests, and I think you need to sell me a little harder on the proposal-begins field.

Thanks for the review and really good feedback. I've implemented the changes you requested and replied with my sales pitch.

caindy commented 3 months ago

Just a note about the broken build--the Spectral linter is wrong here, it's just not setup to look through the allOf attributes that are brought in. image I'll try to figure a way to keep this DRY yet make the linter happy.

getorymckeag commented 3 months ago

Just a note about the broken build--the Spectral linter is wrong here, it's just not setup to look through the allOf attributes that are brought in. image I'll try to figure a way to keep this DRY yet make the linter happy.

Approved, I'm guessing you want to make the linter happy before merging? I'll re-approve after the cosmetics are handled.