Closed catkins-miso closed 3 months ago
As usual, you're a fantastic writer. But yes, I do have some requests, and I think you need to sell me a little harder on the
proposal-begins
field.
Thanks for the review and really good feedback. I've implemented the changes you requested and replied with my sales pitch.
Just a note about the broken build--the Spectral linter is wrong here, it's just not setup to look through the allOf
attributes that are brought in.
I'll try to figure a way to keep this DRY yet make the linter happy.
Just a note about the broken build--the Spectral linter is wrong here, it's just not setup to look through the
allOf
attributes that are brought in.I'll try to figure a way to keep this DRY yet make the linter happy.
Approved, I'm guessing you want to make the linter happy before merging? I'll re-approve after the cosmetics are handled.
The primary updates are:
proposal-begins
in forecast proposal header