search

trolster / urcli

CLI tool for the Udacity Reviews API
MIT License
100 stars 23 forks source link

Pushbullet notification error #114

Closed kartikarora closed 7 years ago

kartikarora commented 7 years ago

Guidelines to submit an issue

I'm opening this issue because:

What's going wrong?

I've been getting this strange error lately

Creating or updating submission request..uncaught exception: Error: Pushbullet error: Error: Pushbullet Pro is required to make this call.
    at /usr/lib/node_modules/urcli/lib/commands/assign/checkAssigned.js:47:30
    at PushBullet.handleError (/usr/lib/node_modules/urcli/node_modules/pushbullet/lib/pushbullet.js:126:5)
    at PushBullet.handleResponse (/usr/lib/node_modules/urcli/node_modules/pushbullet/lib/pushbullet.js:98:8)
    at Request._callback (/usr/lib/node_modules/urcli/node_modules/pushbullet/lib/internal/pushes.js:156:8)
    at Request.self.callback (/usr/lib/node_modules/urcli/node_modules/request/request.js:188:22)
    at emitTwo (events.js:106:13)
    at Request.emit (events.js:191:7)
    at Request.<anonymous> (/usr/lib/node_modules/urcli/node_modules/request/request.js:1171:10)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)

How can the urcli team reproduce the problem?

Setup urcli with PushBullet, wait for a submission to be assigned. As soon as one is assigned, this error shows up briefly and no notification is sent to my PushBullet account

supporting information:

kartikarora commented 7 years ago

I checked the pushbullet pricing page, API access is available in the free version

gabraganca commented 7 years ago

Hi @kartikarora thanks for reporting.

This is very odd. Have you tried generating a new API key with PushBullet and reconfiguring urcli?

kartikarora commented 7 years ago

@gabraganca I did. Still the same.

gabraganca commented 7 years ago

I think I found a similar issue RocketMap/PokeAlarm#118.

Could it be possible that you went above the maximum threshold of 500 API calls this month?

kartikarora commented 7 years ago

500 api calls this month is only possible if I had a submission and urcli kept restarting. I haven't done more than 70 reviews this month.

gabraganca commented 7 years ago

Is it possible that urcli kept restarting?

Sinapse87 commented 7 years ago

Yes, that is the cause. Grep the log and you will see more than 500 restarts

gabraganca commented 7 years ago

@Sinapse87 may I ask you what log?

trolster commented 7 years ago

It sounds like another result of connectivity issues on Udacity's side. It would be quite a hassle to implement something that avoided reaching the cap on PushBullet API calls, so I think this is going to end up not being fixed. I've always thought I should have gone with email notifications instead, but that ship has sailed (unless someone wants to implement that).

Alternatively, Udacity could implement an email service, through the API, so that you can ask for an email confirmation when a project is assigned. Do you guys think that would remove the need for PushBullet?

Sinapse87 commented 7 years ago

I do not think this issue is going to happen again. They had some major connectivity issue with Amazonws these days. But if that does not happen again, we should be fine with the notification cap

trolster commented 7 years ago

@Sinapse87 So you would prefer PushBullet over email? I've never used PushBullet, so I honestly don't know what the advantages are.

Sinapse87 commented 7 years ago

That for sure. PushBullet is a brilliant piece of software!

trolster commented 7 years ago

@Sinapse87 Can you tell me what the advantages are? :smile: I mean, over email for instance?

Sinapse87 commented 7 years ago

You get a push notification on all your devices (I am constantly using three devices), that contains the url of review so you can access immediately. You can share stuff between all your devices. You can disable/enable notification only for a specific app like I do some time on my corporate laptop...

kartikarora commented 7 years ago

@trolster Emails are a pain to manage IMO. Pushbullet notifications can be just swiped away, but not emails. They keep on collecting in the inbox and before you know it you have over 1000 unread emails.

trolster commented 7 years ago

OK, so no reason to remove PushBullet. But I do think that email as an alternative could be used in a similar manner with filters. There are obvious drawbacks to PushBullet, including a signup process, having to use an API key, as well as the API limit. But from your answers I don't really see a need to make any changes.

Kan I close this one @kartikarora?

kartikarora commented 7 years ago

Yes sure. Since we have established it's not a urcli error, its safe to close the issue.