trolster / urcli

CLI tool for the Udacity Reviews API
MIT License
100 stars 23 forks source link

crtl-c to cancel request fails to exit #79

Closed giladgressel closed 7 years ago

giladgressel commented 7 years ago

Guidelines to submit an issue

I'm opening this issue because:

What's going wrong?

When I hit ctrl-c I get an error instead of closing the request.

How can the urcli team reproduce the problem?

Use crtl-c ? Here is my screenshot

screen shot 2017-05-30 at 1 51 36 pm

supporting information:

trolster commented 7 years ago

I was able to replicate this and will investigate asap.

trolster commented 7 years ago

I can't explain this one, except to say I feel sure someone changed the details of what is returned from the API when you delete your request. 9046be3a3163594cf9c7c9335f99f5eb6f71bf7c should fix this. Update to v4.0.1 and see if it works.

trolster commented 7 years ago

I did a sanity check and asked the API developers if they had changed anything, and they said they haven't changed anything for the past 15 days. So I don't know how this becomes a problem all of a sudden. But it seems to be fixed now in 4.0.1. @giladgressel let me know if it works for you.

trolster commented 7 years ago

@giladgressel could you let me know if this works for you after the update?

giladgressel commented 7 years ago

Hi sorry for the delay. Yes 4.0.1 fixes this for me.