trolster / urcli

CLI tool for the Udacity Reviews API
MIT License
100 stars 23 forks source link

Urcli assigns project that is not being pulled! #90

Closed adbelis closed 7 years ago

adbelis commented 7 years ago

Guidelines to submit an issue

I'm opening this issue because:

What's going wrong?

I am certified for two projects A & B, but choose to pull request for Project A only. However, when I run the command urcli assign for A, I am getting notification for Project B.

supporting information:

trolster commented 7 years ago

Hi @adbelis, I think I mistakenly closed the other issue before you had a chance to report on any changes. Sorry about that!

So let me get this straight: You are request project A, but only getting project Bs assigned?

adbelis commented 7 years ago

Thanks for your kind response @trolster .

However, that's not exactly the case.

trolster commented 7 years ago

What kind of notification are we talking about? Can you get more specific? Like, let me know what project IDs and names you are requesting and take me through exactly what is happening. If you have screenshots or you can paste in the text from the UI, that is super helpful too.

adbelis commented 7 years ago

Thanks again. By Notification, I mean project assigned.

trolster commented 7 years ago

Also, try pressing the o key ("o" as in options), and select the debugging information. Paste it in. I will need you to be a lot more specific if I'm to help you :-).

trolster commented 7 years ago

Are the notifications correct? Do you actually get the reviews assigned that the notifications say you do?

adbelis commented 7 years ago

The Debugger shows that I am actually pulling request for just one project. Which is the right thing. And that is what worries me. If it is clear that I am pulling just one, then why is the other one still coming in?

Ok Let me elaborate.

Could this be clear enough?

adbelis commented 7 years ago

Here is the debug info

Debug INFO:
List of request IDs (2): 382327,382861
Submission Request returned from the server: {
  "user_id": 17050,
  "id": 382861,
  "submission_id": null,
  "closed_at": "2017-06-14T14:01:16.070Z",
  "created_at": "2017-06-14T11:02:51.031Z",
  "updated_at": "2017-06-14T13:01:16.082Z",
  "status": "available",
  "submission_request_projects": [
    {
      "project_id": 5,
      "language": "en-us"
    }
  ]
}
Stored Submission Request object: {
  "user_id": 17050,
  "id": 382861,
  "submission_id": null,
  "closed_at": "2017-06-14T14:01:16.070Z",
  "created_at": "2017-06-14T11:02:51.031Z",
  "updated_at": "2017-06-14T13:01:16.082Z",
  "status": "available",
  "submission_request_projects": [
    {
      "project_id": 5,
      "language": "en-us"
    }
  ]
}
trolster commented 7 years ago

That is clear, and it's a total mystery why that would happen. As you can see, the submission_request object that is returned from the servers, clearly show that you are only queued up for project_id 5. Remember that if you manually assign a project, using the dashboard, urcli will still notify you about it.

adbelis commented 7 years ago

I understand very well what you're saying @trolster . And I am very thankful to you for your indulgence.

Am as equally mystified by this too. I rarely manually assign a project from my dashboard. I Usually wait for the Notification from urcli. And when I see in the notification that I am assigned a project that I am not pulling, am stunned.

trolster commented 7 years ago

And just to be clear, the actual project, when you go to the dashboard to look, is it actually a Movie Trailer Website project?

adbelis commented 7 years ago

Yes. And I am not making any request for that. The Project just comes in on its own, and I am not sure where its coming from because I am not making any request for it.

trolster commented 7 years ago

No, I can see that you are requesting project_id 5, not 2..

Well, I think I can safely say that this isn't a urcli issue. It simply has to be an API issue, since urcli doesn't change the SR (submission_request object) and cannot control what is being assigned. When the SR only contains project_id 5, then that is what the API itself is using. So urcli is creating the correct SR, and the API is assigning incorrect projects.

All I can recommend that you do is to write in to reviews support and put "urgent" in the subject line, so that they look at it asap. Let me know how it goes.

adbelis commented 7 years ago

You are right that I am requesting Project 5, not 2, but project 2 keeps coming in.

Fair enough, I have written to review yesterday about this. Still waiting for a response. I will let you know if anything comes up.

trolster commented 7 years ago

Closing this as it's not a urcli issue, but I'd still like to hear what Udacity's response is, so let me know somehow when they get back to you.

adbelis commented 7 years ago

Hey @trolster, the Udacity team just got back to me. They are already aware of the problem, and the engineers are working on the Review API.

Thanks once again for your patience.

trolster commented 7 years ago

OK, thanks for getting back to me! Good luck with the reviewing.