search

trolster / urcli

CLI tool for the Udacity Reviews API
MIT License
100 stars 23 forks source link

Strange error from the API #97

Closed gabraganca closed 7 years ago

gabraganca commented 7 years ago

What's going wrong?

Sometimes I get the following error from assign

The API is returning the following error: "Error: getaddrinfo ENOTFOUND review-api.udacity.com review-api.udacity.com:443"

Then, urcli crashes.

I would say that this is a problem with the API and not with urcli. If that is the case, we can close this and I'll forward this to the support team at Udacity.

It is worth mentioning that I am running it on a server which should have fast internet connection

How can the urcli team reproduce the problem?

Let urcli assign run.

supporting information:

trolster commented 7 years ago

Hi @gabraganca this has been reported on slack also. It's definitely a new thing. It's a DNS error, and I have no idea why it's happening. You should forward it to the reviews team and I'll leave this up in case someone else comes here with the same issue.

gabraganca commented 7 years ago

I got another error from the API which crashed urcli. Unfortunately, I was not fast enough and I lost my position in the queue.

Would it be possible to detect if the error comes from the API and, if yes, it shows the error but keeps urcli opens?

If this is possible, I can try to implement it.

trolster commented 7 years ago

I think the only good way to do this would be to implement logging and deal with one crash at a time, so that we actually know whats going on. I want to know what Udacity has planned before I start to implement new features, but in the mean time you could take a look at https://www.npmjs.com/package/forever. I'd be very interested in whether it works!

gabraganca commented 7 years ago

That's interesting. I 'll try running it.

gabraganca commented 7 years ago

This should probably be fixed after the API update.