search

trombik / AS3935-ESP-I2C

AS3935 I2C library for ESP8266
5 stars 4 forks source link

Arduino IDE compliance #10

Open tobozo opened 6 years ago

tobozo commented 6 years ago

Reason for this PR: the library wasn't detected when unzipped in the Arduino/libraries folder.

So I moved the example file and added the library.properties file, also updated the travis script so it reflects those changes.

https://travis-ci.org/tobozo/AS3935-ESP-I2C/builds/409229726

I have tested this library successfully on Arduino IDE 1.8.5 with an ESP32.

If you consider producing a tag + release, your library can be added to the Arduino Library Manager by opening an issue (edit: you may need to add a ReadMe file though).

Thanks for you great work! :+1 :bowing_man:

trombik commented 6 years ago

thanks for the PR. I am sorry to inform that i am re-writing the library so that it supports multiple arch and I2C implementations. https://github.com/trombik/TRB_AS3935 currently supports esp-idf native I2C and arduino Wire. if you are happy with Wire, it should work with esp8266.

as for arduino IDE support, I am not sure that it's possible because i would like to choose I2C backend, say, brzo I2C or WIre on esp8266. arduino build environment, as far as I know, cannot define build flags via IDE. variables for build, like ARDUINO and ESP8266, are not enough to choose I2C library.

will make this repo an archive.