search

trongate / trongate-framework

The Trongate PHP framework
https://trongate.io
Other
1.12k stars 100 forks source link

missing method remove_special_characters in class Validation_helper #137

Closed jchouix closed 1 year ago

jchouix commented 1 year ago

Hi, the method remove_special_characters does not exist in the class Validation_helper in the file engine/tg_helpers/validation_helper.php at line 420 Best regards.

trongate commented 1 year ago

Thank you. That's awesome. I will look into this shortly. I appreciate your pull request too. Great stuff. Just waiting for a moment when I have a little time to tune into this. Many thanks. I'll be in touch shortly. - DC

trongate commented 1 year ago

Okay. I've had a look at it. The obvious solution appears to be adding a remove_special_characters function. However, as suggested in a previous message, I think the whole idea of having unique() is deeply flawed. There is no remove_special_characters function I can imagine that could be applied universally. In other words, the moment Trongate gets adopted by developers who build sites that use non-English languages, our unique function will be more of a hinderance than a help. I think this is a big old bag of problems and the real solution is to ditch unique.

Do you agree?

jchouix commented 1 year ago

Yes.

trongate commented 1 year ago

Okay, I have now removed 'unique'. Thanks for raising this.