search

trongate / trongate-framework

The Trongate PHP framework
https://trongate.io
Other
1.11k stars 100 forks source link

bug fixes in Trongate_pages.php about the number of records selected per page #179

Closed jchouix closed 1 month ago

jchouix commented 3 months ago

fix a bug with the selection of the number of records selected and displayed in a page which does not work correctly.

trongate commented 2 months ago

Thank you SO MUCH for this pull request. We're all really grateful. At the moment, Trongate Pages is being rewritten completely. It will look precisely the same and there should not be any breaking changes. Nevertheless, we're currently looking at a way to make Trongate Pages work with far less JavaScript and that requires quite a lot of work. Because of this, your pull request is causing merge conflicts. So, may I ask you to just hold your horses with that one, for now? It's probably a cool request but I wonder if you'd be okay waiting a while with this one.

jchouix commented 2 months ago

No problem. I will respect your decision whatever it is. Best regards.

trongate commented 1 month ago

UPDATE: I have added a temp fix to Trongate Pages that might use code similar to yours. I am very eager to have you on the contributors list and I certainly want to give you credit for cool ideas that you've given us. So, please get back to me if you want to get onto the contributors list. I'll figure out a way to make that happen, if you want. Hail jchouix!