trongate / trongate-framework

The Trongate PHP framework
https://trongate.io
Other
1.11k stars 100 forks source link

Modifications to Image Class #194

Closed domsinclair closed 1 month ago

domsinclair commented 1 month ago

During the documentation process certain small but fundamental changes were made to this class which unfortunately broke the news module and will also break modules using the single picture uploader.

That this is the case can be verified by doing the following.

1 create a new trongate app 2 add the news module to it (from the module market) 3 open any news article in edit mode, delete the existing picture and attempt to upload a new one.

You will get a series of errors

This pr sets out to correct those by adding redirects for method names that were changed and returning the save method to being public. Making it protected would only have worked if Trongate employed namespaces.

trongate commented 1 month ago

Thank you. Hail Dom!