trongtd1988 / flv4php

Automatically exported from code.google.com/p/flv4php
0 stars 0 forks source link

Possible case error #5

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What is the expected output? What do you see instead?
When trying to figure out why the $skipTagTypes array was not working, I
found that there were some apparent incorrect case issues:
./test2.php:                if ( !in_array(FLV_TAG::TYPE_VIDEO,
$skipTagTypes) )
./play.php:                     if ( !in_array(FLV_TAG::TYPE_VIDEO,
$skipTagTypes) )

Those are the only two instances where the "TAG" portion of "FLV_TAG" is
all upper case. All other instances including class naming are "FLV_Tag"
with "Tag" being sentence case. This didn't resolve the $skipTagTypes
problem with it not skipping AUDIO tags, but I thought it was worth reporting.

What version of the product are you using? On what operating system?
Trunk r26, PHP 5.2.5, Debian

Original issue reported on code.google.com by gera...@gmail.com on 17 Jul 2008 at 5:33

GoogleCodeExporter commented 8 years ago
you are correct, What would you sugest we change it to ? i have not worked on 
the php
5 version in ages. since i still dont have a php5 host.

Original comment by fan...@gmail.com on 22 Jul 2008 at 10:11

GoogleCodeExporter commented 8 years ago
You can switch those two instances of FLV_TAG to FLV_Tag. It will then match 
the rest
of the code.

Original comment by gera...@gmail.com on 22 Jul 2008 at 11:15

GoogleCodeExporter commented 8 years ago

Original comment by fan...@gmail.com on 27 Jul 2008 at 11:32