search

tronprotocol / tronwallet-adapter

MIT License
59 stars 29 forks source link

OKX deeplink should use encodeURIComponent #47

Closed alienzhangyw closed 5 months ago

alienzhangyw commented 7 months ago

See OKX docs here https://www.okx.com/cn/web3/build/docs/sdks/app-universal-link#%E6%AD%A5%E9%AA%A4-2%EF%BC%9A%E7%BC%96%E7%A0%81-deeplink-%E5%8F%82%E6%95%B0

const encodedDappUrl = encodeURIComponent(dappUrl);
const deepLink = "okx://wallet/dapp/url?dappUrl=" + encodedDappUrl;

In currenet version of OKX adapter, if these is any special character (%, +, etc) in dapp url, the link opened in OKX app's browser will be wrong.

way2ex commented 7 months ago

Thanks a lot for your remind. We will update the package soon.

way2ex commented 5 months ago

Hi, v1.0.3 has been released. Please update the package version and check the deeplink functionality.

alienzhangyw commented 5 months ago

Hi, v1.0.3 has been released. Please update the package version and check the deeplink functionality.

Thanks, although we are not using this with OKX wallet now.