search

tronprotocol / tronweb

Javascript API Library for interacting with the TRON Network
MIT License
423 stars 271 forks source link

Adding missing callback param to _getTriggerSmartContractArgs #425

Closed corymsmith closed 11 months ago

corymsmith commented 11 months ago

As you can see here, the variable callback is not defined:

https://github.com/tronprotocol/tronweb/blob/d2a300aedf1b1ce0e9008f424f77988752d2ecd1/src/lib/transactionBuilder.js#L1351

start940315 commented 11 months ago

We removed the usage of callback on this method. Please try using promise.

corymsmith commented 11 months ago

I was using a promise and was never using a callback, the callback issue was happening internally to tronweb, please look at where the variable was missing.

On Thu, Sep 28, 2023 at 8:29 PM start940315 @.***> wrote:

Closed #425 https://github.com/tronprotocol/tronweb/pull/425.

— Reply to this email directly, view it on GitHub https://github.com/tronprotocol/tronweb/pull/425#event-10506066643, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABZE7HTWL2ZSVGUGFDK3TX4YXCLANCNFSM6AAAAAA5AOPXUA . You are receiving this because you authored the thread.Message ID: @.***>

start940315 commented 11 months ago

It seems like you have put some error data in parameter argument. We have fixed the callback problem in v6, thank you for your pr.