trophia / sna1

A model of the SNA1 fishery
2 stars 2 forks source link

Proposal to make age an explicit characteristic of an agent #28

Closed Craig44 closed 6 years ago

Craig44 commented 6 years ago

I have been messing around and found that I get a better comparison between CASAL and the ABM when I make age an explicit characteristic of the agent and age it in the growth() function. This differs from the current situation where we imply age, where age = current_year - birth year. I have attached figures and I can add models if anyone is interested. But basically I turned off fishing and these models are purely M and recruitment (with varying devs). The top figure is current implementation and bottim figure is with age explicit. Th code for the bottom figure is coded here current_parameterisation best_fit

These seem like trivial differences but, I think if Casal is going to be the re-estimation model we should align the dynamics as closely as possible? any thoughts on this. I can do a pull request if you agree.