trophygeek / universalvideomaximizer

Chrome extension that finds and enlarges the main video filling browser window.
Creative Commons Attribution Share Alike 4.0 International
31 stars 2 forks source link

[BUG] Black Screen When Maximized on haitu.tv #51

Open Steven-yy-Zhou opened 11 months ago

Steven-yy-Zhou commented 11 months ago

Fill out what you can below

Describe the bug Not sure if this is just me, but happens to me on quick a few pages, the screen turns black when it's maximized, sites like Youtube are still working correctly.

[A clear and concise description of what the bug is.] INCLUDE SITE OR URL DETAILS LIKE:

SCREENSHOT OR VIDEO Removed video

[Very helpful to see a screenshot or video. You can drag upload them into this bug. If it's an adult site or may require login, then you should email me directly trophygeek@gmail]

Steps to Reproduce if complicated Steps to reproduce the behavior:

(Example)

  1. Go to ____
  2. Click on ____
  3. Scroll down to ____
  4. See error ____

Expected behavior [A clear and concise description of what you expected to happen.] Video continue playing without turning into black screen.

Help Version info:

trophygeek commented 11 months ago

Good news: I was able to reproduce the problem. More good news: It should be fixed in the next release.

I will update this bug when the store has the next update deployed (it can take some time).

Steven-yy-Zhou commented 11 months ago

excellent, thank you!

trophygeek commented 11 months ago

This version has finally been updated in store. Let me know if it fixes the issue you're seeing.

Steven-yy-Zhou commented 11 months ago

Just to confirm the version number is 3.0.112.

It no longer zooms the video, also disabling advanced feature doesn't remove the playback speed control panels anymore. (I just want a simple zoom and unzoom button.

https://github.com/trophygeek/universalvideomaximizer/assets/22750166/b4d9de18-c35d-4b7c-8f4b-b60cae347eac

trophygeek commented 10 months ago

Thanks for the video. It's very helpful.

Yeah. I broke this feature when I removed the tutorial feature. "Simple mode" should be working again. Latest version is 3.0.115

Steven-yy-Zhou commented 10 months ago

can confirm the "simple mode" is working (no playback speed control anymore), but the video is still not zoomed when it's activated.

trophygeek commented 10 months ago

Umm... Let me double check it.

Making all sites zoom can be tricky. Fixing one site often breaks another and there's NOT consistent way sites embed videos. Many put them in iframe.

To make everything MORE difficult, it's almost impossible to write tests for extensions that inject code into sites.

trophygeek commented 10 months ago

OK. Confirmed it's broken again. Not sure if the site changed or it's something in the extension.

I'll dig into some more and leave this bug open.