search

tropicdome / MyPetBattle

6 stars 7 forks source link

enhancement: don't auto-dismiss pet if the summoned pet is not the same as the slot 1 pet #17

Closed joevt closed 11 years ago

joevt commented 11 years ago

Allow the player to show off their pets by not auto dismissing the pet when the summoned pet is not the same as the slot 1 pet.


        -- Dismiss pet so we do not have it running around
        local petGUID = C_PetJournal.GetSummonedPetGUID()
        if petGUID and petGUID == C_PetJournal.GetPetLoadOutInfo(1) then -- Check if we have a pet summoned already, or we will get an error
            C_PetJournal.SummonPetByGUID(petGUID) -- Dismiss pet
        end
tropicdome commented 11 years ago

Thank you, I have added it and will push it soon.

It is also good if you want to use battle stones to upgrade a pet, so it will not dismiss it before you get the chance to upgrade it.

spammatuamamma commented 11 years ago

a stupd question on this... how do i use the battle stone? It does not let me right click on it...

Sorry for using this as a "helpline" but you guys know so much!!!

BTW KUDOS... awesome addon

On 7 Jul 2013, at 22:18, tropicdome notifications@github.com wrote:

Thank you, I have added it and will push it soon.

It is also good if you want to use battle stones to upgrade a pet, so it will not dismiss it before you get the chance to upgrade it.

— Reply to this email directly or view it on GitHub.

joevt commented 11 years ago

Click on the pet in the pet list and click Summon. Make sure the pet isn't the same as the one in the first of the 3 slots since that one is automatically dismissed by the add-on.

When the pet is summoned, right click the battle stone and click the summoned pet which is standing next to your character. Then you can manually dismiss the pet after it's been upgraded by the battle stone.

spammatuamamma commented 11 years ago

thanks - apparently i had to disable the addon, maybe a bug? no matter what i had on the pet journal, it would dismiss the pet nonetheless... On 7 Jul 2013, at 22:40, joevt notifications@github.com wrote:

Click on the pet in the pet list and click Summon. Make sure the pet isn't the same as the one in the first of the 3 slots since that one is automatically dismissed by the add-on.

When the pet is summoned, right click the battle stone and click the summoned pet which is standing next to your character. Then you can manually dismiss the pet after it's been upgraded by the battle stone.

— Reply to this email directly or view it on GitHub.

joevt commented 11 years ago

The fix was made only four hours ago. Make sure you're using version 1.0.9.