tropy / tropy-plugin-iiif

Tropy plugin to import IIIF manifests
GNU Affero General Public License v3.0
14 stars 3 forks source link

Import of IIIF Manifest Caused Tropy to Crash #5

Open cyocum opened 8 months ago

cyocum commented 8 months ago

I attempted to import the IIIF manifest from here https://www.isos.dias.ie/NLS/NLS_Adv_MS_72_1_6.html (see https://www.isos.dias.ie/static/manifests/NLS_Adv_MS_72_1_6.json?manifest=https://www.isos.dias.ie/static/manifests/NLS_Adv_MS_72_1_6.json) into Tropy. This started the process of importing and seemed to be going fine until Tropy crashed with a dialog box. I was able to get the logs from Tropy which I have attached to this issue. crash_tropy.log

flachware commented 8 months ago

@inukshuk Tropy does not crash for me, but some resources (from image f. 7 r on) can’t be loaded because they exceed the maximum pixel threshold of the configuration: https://iiif.isos.dias.ie/iiif/2/NLS%2FNLS_Adv_MS_72_1_6%2F13.tif/full/full/0/default.jpg. I assume they expect tiling.

cyocum commented 8 months ago

Is there a way around this? I would assume that if this happens here, it will happen elsewhere.

inukshuk commented 8 months ago

I don't think there is a way for us to know what size the server permits. The fetch request is without any dimensions so I'd think that the server should figure out safe default values?

cyocum commented 7 months ago

OK, thanks for looking into it. I don't think there is anything more that I could do. I don't have access to the underlying server code to fix and asking for a change probably will not help.

wragge commented 6 months ago

Tropy is also crashing for me when I try to import an IIIF manifest.

The manifest is here: https://contentdm.lib.byu.edu/iiif/info/p15999coll21/18821/manifest.json

Log: {"level":30,"time":1705635651760,"type":"browser","name":"main","args":[],"opts":{"env":"production","autoUpdates":true,"contextIsolation":true,"webgl":false,"verbose":false,"trace":false,"data":"/home/tim/.config/tropy","cache":"/home/tim/.cache/tropy","logs":"/home/tim/.config/tropy/log"},"version":"1.15.2","msg":"main.init 1.15.2 Linux 6.5.6-76060506-generic (x64)"} {"level":30,"time":1705635651777,"type":"browser","name":"main","msg":"plugins scanned: 1"} {"level":30,"time":1705635651777,"type":"browser","name":"main","msg":"app state restored"} {"level":30,"time":1705635651778,"type":"browser","name":"main","file":"/home/tim/Downloads/tropy/test.tropy","msg":"open new project window"} {"level":30,"time":1705635651899,"type":"browser","name":"main","status":{"2d_canvas":"enabled","canvas_oop_rasterization":"disabled_off","direct_rendering_display_compositor":"disabled_off_ok","gpu_compositing":"enabled","multiple_raster_threads":"enabled_on","opengl":"enabled_on","rasterization":"enabled","raw_draw":"disabled_off_ok","video_decode":"enabled","video_encode":"disabled_software","vulkan":"disabled_off","webgl":"enabled","webgl2":"enabled","webgpu":"disabled_off"},"msg":"gpu-info-update"} {"level":30,"time":1705635651914,"type":"renderer","name":"project","dpx":1.25,"args":{"frameless":true,"locale":"en","webgl":true,"zoom":1},"msg":"project.init"} {"level":30,"time":1705635651921,"type":"renderer","name":"project","msg":"plugins scanned: 1"} {"level":30,"time":1705635651922,"type":"renderer","name":"project","msg":"plugins loaded: 1"} {"level":30,"time":1705635652085,"type":"browser","name":"main","msg":"ready after 1108ms"} {"level":30,"time":1705635652079,"type":"renderer","name":"project","msg":"restoring projectFiles@tropy"} {"level":30,"time":1705635652079,"type":"renderer","name":"project","msg":"restoring recent@tropy"} {"level":30,"time":1705635652079,"type":"renderer","name":"project","msg":"restoring settings@tropy"} {"level":30,"time":1705635652079,"type":"renderer","name":"project","msg":"restoring ui@tropy"} {"level":30,"time":1705635652080,"type":"renderer","name":"project","mode":"w+","msg":"open db /home/tim/.config/tropy/ontology.db"} {"level":30,"time":1705635652339,"type":"renderer","name":"project","mode":"webgl","resolution":1,"msg":"Esper.instance created with webgl renderer"} {"level":30,"time":1705635652352,"type":"renderer","name":"project","mode":"w","msg":"open db /home/tim/Downloads/tropy/test.tropy/project.tpy"} {"level":30,"time":1705635652395,"type":"renderer","name":"project","msg":"restoring project.watch@9472a050-1298-4269-bfe1-983f2d633133"} {"level":30,"time":1705635652396,"type":"renderer","name":"project","msg":"restoring project.watch@9472a050-1298-4269-bfe1-983f2d633133"} {"level":30,"time":1705635652396,"type":"renderer","name":"project","msg":"restoring nav@9472a050-1298-4269-bfe1-983f2d633133"} {"level":30,"time":1705635652396,"type":"renderer","name":"project","msg":"restoring notepad@9472a050-1298-4269-bfe1-983f2d633133"} {"level":30,"time":1705635652396,"type":"renderer","name":"project","msg":"restoring esper@9472a050-1298-4269-bfe1-983f2d633133"} {"level":30,"time":1705635652396,"type":"renderer","name":"project","msg":"restoring imports@9472a050-1298-4269-bfe1-983f2d633133"} {"level":30,"time":1705635652396,"type":"renderer","name":"project","msg":"restoring sidebar@9472a050-1298-4269-bfe1-983f2d633133"} {"level":30,"time":1705635652397,"type":"renderer","name":"project","msg":"restoring panel@9472a050-1298-4269-bfe1-983f2d633133"} {"level":30,"time":1705635652399,"type":"renderer","name":"project","mode":"w","msg":"open db /home/tim/Downloads/tropy/test.tropy/project.tpy"} {"level":30,"time":1705635652400,"type":"renderer","name":"project","mode":"w","msg":"open db /home/tim/Downloads/tropy/test.tropy/project.tpy"} {"level":30,"time":1705635652412,"type":"renderer","name":"project","msg":"project ready 607ms [dom:112ms init:13ms load:150ms]"} {"level":30,"time":1705635659668,"type":"renderer","name":"project","cache":{"memory":{"current":0,"high":0,"max":50},"files":{"current":0,"max":20},"items":{"current":0,"max":100}},"concurrency":1,"simd":true,"msg":"sharp initialized"} {"level":40,"time":1705635667032,"type":"browser","name":"main","msg":"project[1] render-process crashed: crashed"}

inukshuk commented 6 months ago

Can you import any other images or does this only happen when you import via IIIF?

It could be related to a crash in the bundled libvips library that we've been seeing on some Linux distros. If that's the case it might help to install Tropy via Flatpak because there libvips is linked against all the libraries inside the container.

wragge commented 6 months ago

On Pop-OS with Tropy run from the download package, individual images import ok, but folders or groups crash the same way as IIIF manifests.

But I just installed Tropy via Flatpak and all seems good -- have downloaded images from a couple of large manifests without any problems. Thanks!