trotsky / insyde-tools

(Inactive) Tools for unpacking and modifying an InsydeH2O UEFI BIOS now merged into coreboot
http://review.coreboot.org/gitweb?p=bios_extract.git;a=summary
MIT License
26 stars 8 forks source link

Merging request #1

Open XVilka opened 12 years ago

XVilka commented 12 years ago

Coreboot and Flashrom projects have tool, bios_extract - see http://review.coreboot.org/gitweb?p=bios_extract.git;a=tree . What do you think about merging your code in this tool?

stefanct commented 12 years ago

Hi,

i have prepared the existing code to be merged into the bios_extract repository. You can follow this process at http://review.coreboot.org/#/q/project:bios_extract+message:insyde,n,z

If you would like to further contribute directly you should read http://www.coreboot.org/Git else you can always drop us a mail (coreboot@coreboot.org) with patches too.

I hope there are no bad feelings about this "hijack", introducing such was not intended of course. I'd like to concentrate all related tools in one repository though to be able to refactor them to eventually create a single library that is able to prepare images for the use with flashrom.

trotsky commented 11 years ago

Sorry for the lengthy delay in responding. Far from upset, I'm quite pleased it was able to benefit coreboot as I hold the project in high regard. And I'm grateful for the effort you put in to resolve the licensing issues, clean it up and give it a permanent home.

I've modified the readme and repo url to direct anyone interested to your code review system. If you'd prefer different inbound links or other changes I'm happy to oblige.

I'm honestly unsure what if any code in the main branch was mine. I think you're all set but I figured I would formally state that all contributions I made in any branch were intended to be MIT licensed and match the original authors.

If I do pick the work up again I'll certainly rebase on your editions and aim for low friction patch sets.

Thanks again - especially for not letting me hold you up.