trotyl / angular-contrib

Community extension to Angular framework
MIT License
65 stars 7 forks source link

Conflict of Renderer2 typing extension with Angular 9 #234

Open Pedro-vk opened 4 years ago

Pedro-vk commented 4 years ago

There is a small conflict with the Renderer2 extension with Angular 9 animations.

    ERROR in node_modules/@angular/platform-browser/animations/animations.d.ts:71:22 - error TS2720: Class 'ɵangular_packages_platform_browser_animations_animations_f' incorrectly implements class 'Renderer2'. Did you mean to extend 'Renderer2' and inherit its members as a subclass?
      Property 'childNodes' is missing in type 'ɵangular_packages_platform_browser_animations_animations_f' but required in type 'Renderer2'.

    71 export declare class ɵangular_packages_platform_browser_animations_animations_f implements Renderer2 {
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

      node_modules/@angular-contrib/core/render-extension/render-extension.module.d.ts:5:9
        5         childNodes(node: Node): NodeList;
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        'childNodes' is declared here.
    node_modules/@angular/platform-browser/animations/animations.d.ts:102:22 - error TS2720: Class 'ɵAnimationRenderer' incorrectly implements class 'Renderer2'. Did you mean to extend 'Renderer2' and inherit its members as a subclass?
      Property 'childNodes' is missing in type 'ɵAnimationRenderer' but required in type 'Renderer2'.

    102 export declare class ɵAnimationRenderer extends ɵangular_packages_platform_browser_animations_animations_f implements Renderer2 {
                             ~~~~~~~~~~~~~~~~~~

      node_modules/@angular-contrib/core/render-extension/render-extension.module.d.ts:5:9
        5         childNodes(node: Node): NodeList;
                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        'childNodes' is declared here.
ebeuker commented 4 years ago

Can you please publish a new version of this library to npm with this fix