trotyl / ng-vdom

(Developer Preview) A virtual-DOM extension for Angular, also work as React bridge.
260 stars 12 forks source link

feat(core): invoke willUnmount callback properly #79

Closed trotyl closed 5 years ago

trotyl commented 5 years ago

closes #42

codecov[bot] commented 5 years ago

Codecov Report

Merging #79 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage    90.6%   90.63%   +0.03%     
==========================================
  Files          19       19              
  Lines         532      534       +2     
  Branches       78       78              
==========================================
+ Hits          482      484       +2     
  Misses         26       26              
  Partials       24       24
Impacted Files Coverage Δ
projects/core/src/instructions/class-component.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9159d0c...d55f6e0. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #79 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage    90.6%   90.63%   +0.03%     
==========================================
  Files          19       19              
  Lines         532      534       +2     
  Branches       78       78              
==========================================
+ Hits          482      484       +2     
  Misses         26       26              
  Partials       24       24
Impacted Files Coverage Δ
projects/core/src/instructions/class-component.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9159d0c...d55f6e0. Read the comment docs.