search

troublemaker-dev / Textual

Textual is an IRC client for OS X
https://www.codeux.com/textual/
4 stars 0 forks source link

newline and theme bugs #1

Open nsklaus opened 2 years ago

nsklaus commented 2 years ago

autotheme change is not working correctly when theme change events occur. when macos switch back and forth to dark/light theme, textual try to do it, and do not succeed completely. what happen is that the theme is getting mangled, i see each new line have a 2 line jump, for example.

like this:

this is normal line 1
this is normal line 2

now theme change event occurs:

this is mangled theme line 1

this is mangled theme line 2

notice the blank line between line 1 & 2 there are also other theme-related little problems. to reproduce, make macos auto switch light and dark theme, or make the switch manualy while textual runs in the background. i have textual running 24/7 and this theme change problem appear everyday for me. tested on bigsur, monterey and now ventura.

another problem is that sometime, textual do not scroll automatically when someone enter a new line of text. for example: i type something, and after i press enter, the line is not visible. i need to manualy scroll down to make it appear. when that problem manifests itself, it shows this behavior for everyone's lines, mines and others. the work around is to switch to another channel, then switch back to previous one. the problem might reappear a few minute later though, requiring the workaround to be used again. that problem does not appear as often as the theme problem and i do not know how to reproduce it. but it happens a few times in one or two week. maybe it's linked to the theme problems somehow, i cannot say for sure.

there is also the channels icon missing problem. some channels for unknown reason won't get their icons displayed at all.

kenrachynski commented 2 years ago

The common case for channel icon is in #2.

kenrachynski commented 2 years ago

@nsklaus which theme are you using again?

nsklaus commented 2 years ago

i use the simplified theme

kenrachynski commented 2 years ago

Okay, trying to duplicate this behaviour with auto light/dark and simplified

kenrachynski commented 2 years ago

I have managed to briefly duplicate this with extra behaviours (font was black on black for dark mode). Restarted textual to deal with fonts and line spacing stopped happening. Still switching modes to duplicate again.

nsklaus commented 2 years ago

good to hear you could replicate the problem. fwiw, i never had the black font on black background. but the line spacing is happening everyday. of course, if i restart textual, everything is fine, until the autotheme change on next morning. please note that it's macos that trigger the theme change. i only go to textual prefs when theme is messed up, only then i switch theme to something else and back to "simplified", to force a theme refresh/reload. let me know if you need screenshots or anything i could provide.