union(with: ) appears to be broken

troughton / Substrate

A cross-platform render-graph based rendering system written in Swift

MIT License

151 stars 12 forks source link

union(with: ) appears to be broken #3

Closed nferruzzi closed 7 months ago

nferruzzi commented 7 months ago

https://github.com/troughton/Substrate/blob/987832dd60f46a863a53eb3fbed51167a2853a9a/Sources/SubstrateMath/Primitives.swift#L226

hello Thomas, while debugging I noticed that the 2 function union(with:) compute the union using the minimum of the maximum points, shouldn't it be the maximum?

thanks in advance

troughton commented 7 months ago

Sorry about that; fixed in https://github.com/troughton/Substrate/commit/9032c9c224830c8d77cf35f60eddb6fda23d267c.