search

trouty00 / neeo_driver_sony_bravia

This app brings NEEO and Sony Bravia Android TV's together,
1 stars 1 forks source link

Improvement: optimized macro names for widgets and remote keys #1

Open pfiaux opened 6 years ago

pfiaux commented 6 years ago

I want to suggest some small improvements for button names in this driver.

If some of the buttons were renamed it would allow for better integration with the keys on the remote and some widgets. I understand some of them might not look as nice or as short but they will improve the integration with more widgets and features.

Current name Recommended name
ENTER CURSOR ENTER
SKIP BACKWARD PREVIOUS
SKIP FORWARD NEXT
INPUT TV INPUT TUNER
INPUT INPUT SCROLL

For more details on the widgets and recommended macro names you can take a look at https://github.com/NEEOInc/neeo-sdk/blob/master/lib/device/validation/buttongroup.js

Using the addButtonGroup not only uses the recommended macro names it can also shorten the buttons declaration in index.js.

trouty00 commented 6 years ago

Thanks for the suggestions, the driver isnt getting much of my attention currently but I will add it to the list

regards Stu

On Mon, Apr 9, 2018 at 7:54 AM, Patrick Fiaux notifications@github.com wrote:

I want to suggest some small improvements for button names in this driver.

If some of the buttons were renamed it would allow for better integration with the keys on the remote and some widgets. I understand some of them might not look as nice or as short but they will improve the integration with more widgets and features. Current name Recommended name ENTER CURSOR ENTER SKIP BACKWARD PREVIOUS SKIP FORWARD NEXT INPUT TV INPUT TUNER INPUT INPUT SCROLL

For more details on the widgets and recommended macro names you can take a look at https://github.com/NEEOInc/neeo-sdk/blob/master/lib/ device/validation/buttongroup.js

Using the addButtonGroup not only uses the recommended macro names it can also shorten the buttons declaration in index.js.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/trouty00/neeo_driver_sony_bravia/issues/1, or mute the thread https://github.com/notifications/unsubscribe-auth/ADunG2h_zHB0NTCMCtYv3n3jsCIECqw-ks5tmwWWgaJpZM4TMCBm .

-- skype :stu.trout MSN : trouty00@hotmail.com