search

troy351 / emmet-monaco-es

Emmet support for Monaco Editor
MIT License
78 stars 14 forks source link

monaco `0.37.0` support #109

Closed CetinSert closed 1 year ago

CetinSert commented 1 year ago

Despite https://github.com/troy351/emmet-monaco-es/commit/7e3f116de4d89c898b4b07b384246d4bfc1c874f, emmet-monaco-es 5.2.1 does not work with monaco 0.37.0 ❌; emmet-monaco-es 5.2.1 does work with monaco 0.36.1 ✔️ and 0.36.0 ✔️.

troy351 commented 1 year ago

I'll fix it tomorrow :)

troy351 commented 1 year ago

It seems mangled props was back 😆 https://github.com/microsoft/vscode/pull/177223

troy351 commented 1 year ago

New Version released

CetinSert commented 1 year ago

@troy351 – what would now be the equivalent of the following?

editor.getContribution('editor.contrib.suggestController')?.widget?.value?.X?.(true);

I am trying to display and expand the suggestion box by default.

See https://github.com/troy351/emmet-monaco-es/issues/107

CetinSert commented 1 year ago

Never mind, it went back to

editor.getContribution('editor.contrib.suggestController')?.widget?.value?._setDetailsVisible?.(true);