search

troyanskiy / ngx-resource-core

RESTful Core Library
40 stars 10 forks source link

toObservable support #49

Closed httpete closed 5 years ago

httpete commented 5 years ago

Hi, I see that commented out - can that be enabled? Everyone wants an observable returned instead of promise.

troyanskiy commented 5 years ago

Hello @all I did some refactoring and repository restructuring. From now on new repository is located here https://github.com/troyanskiy/ngx-resource Please create new issues in new repo. I will close all the issues in that repo.

Also I have released 7.0.0-beta.5 version with Observables support. Please test it and create new issues in new repo if you will find some bugs.

To update to new version run npm i --save @ngx-resource/core@beta @ngx-resource/handler-ngx-http@beta

Breaking changes:

ResourceGlobalConfig

IResourceParams and IResourceAction

Deprecation

New

I still have to update Docs and provide migration guide.

Thank you @all !!!

httpete commented 5 years ago

Starting to test now @troyanskiy - thank you. First thing I am hitting is how to configure it globally (as to not break all the promises based invocations)

troyanskiy commented 5 years ago

Thank you for testing.

You can check how to configure here https://github.com/troyanskiy/ngx-resource/issues/151

httpete commented 5 years ago

This is a non standard way to configure a module, a better way would be to have a provider that sets the config, that’s pretty standard if you see things like angular ui router

On Aug 6, 2019, at 2:22 PM, Raman Rasliuk notifications@github.com wrote:

Thank you for testing.

You can check how to configure here troyanskiy/ngx-resource#151

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

troyanskiy commented 5 years ago

@httpete I will implement something new for that.

Thanks for remark.