Multiple Zones with Same name / Public vs. Private for Split DNS

troydieter / r53_backups_cdk

Back up your Amazon Route53 forward zones programmatically using AWS CDK

Apache License 2.0

3 stars 0 forks source link

Multiple Zones with Same name / Public vs. Private for Split DNS #1

Closed tmthbrunner closed 7 months ago

tmthbrunner commented 7 months ago

Great solution... works fantastic. Just wanted to make you aware it does not differentiate between public and private zones. In a split DNS scenario, you could have public and private zones with the same name. It only writes one of them to the s3 bucket currently.

troydieter commented 7 months ago

Thanks for this @tmthbrunner ! That is an accurate point, and one we should rectify. Marking this as a bug and will work to get a change in.

troydieter commented 7 months ago

Hi @tmthbrunner - again, thanks for the very valuable feedback. I've rectified this and pushed a change that now appends _public or _private depending on the Route53 Hosted Zone type.

Tested and working as expected, feel free to re-open any issues pertaining to this if you see otherwise.