troygoode / fvtt-clocks

A module that lets you create Blades in the Dark-esque progress clocks (https://bladesinthedark.com/progress-clocks) within Foundry VTT (https://foundryvtt.com/). Supports both ad hoc Tiles for use in a single scene and long-lasting Actor variants.
https://foundryvtt.com/packages/clocks/
MIT License
7 stars 18 forks source link

Is this abandoned? #10

Open Chromie192 opened 2 years ago

Chromie192 commented 2 years ago

Doesn't work in Foundry 9.0, would love to use it.

tesolberg commented 2 years ago

2nd that.

Codex966 commented 2 years ago

3rded. This was an excellent tool.

Codex966 commented 2 years ago

Nvm, did it myself.

Added Halfwalk's 8.0+ compatibility for tiles.js, added new theme colors (Red, Green, Purple, White), and changes it all to .webp for file size optimization.

https://github.com/Codex966/fvtt-clocks

woodinthehood commented 2 years ago

@Codex966 Thanks for the update. FYI, I think with how you've currently configured it, the original blue and yellow themes don't work, since it's trying to pull .webp files when there's only .jpeg's in those folders. Unless I'm missing something, which is very possible lol

Codex966 commented 2 years ago

@woodinthehood shoot, you're right, I forgot to push the modified images for those folders. I'll update it asap

woodinthehood commented 2 years ago

Also, is the Actor functionality working as intended? At least from the little bit I've worked with it, it doesn't seem like you're able to edit the clock Actor while its out on the map. The icons (+/-, palette, etc) that are supposed to appear around it when you right click don't, and you can't edit it from the toolbar either. Not really my area of expertise, so not sure how to tell what isn't working here unfortunately.

Chromie192 commented 2 years ago

Also, is the Actor functionality working as intended? At least from the little bit I've worked with it, it doesn't seem like you're able to edit the clock Actor while its out on the map. The icons (+/-, palette, etc) that are supposed to appear around it when you right click don't, and you can't edit it from the toolbar either. Not really my area of expertise, so not sure how to tell what isn't working here unfortunately.

I also can't do the same.

And I'm not able to even select the Tile icon for the Clocks.

WolfDeity commented 2 years ago

Nvm, did it myself.

Added Halfwalk's 8.0+ compatibility for tiles.js, added new theme colors (Red, Green, Purple, White), and changes it all to .webp for file size optimization.

https://github.com/Codex966/fvtt-clocks

All of my attempts to install your version just end up with me downloading this version. even the official install link you posted says the newest supported version is 0.7.9.

tesolberg commented 2 years ago

The manifest file links to the original repository of troygoode.

Chromie192 commented 2 years ago

Can you post the mainfest link or something?

kmap01 commented 2 years ago

@Codex966 Hey, so just wanted to make a note that a token on the map/canvas won't update unless you modify line 114 of modules/sheet.js.

diff --git a/modules/sheet.js b/modules/sheet.js
index dd99cd2..e4658a8 100644
--- a/modules/sheet.js
+++ b/modules/sheet.js
@@ -111,7 +111,7 @@ export class ClockSheet extends ActorSheet {
     // update associated tokens
     const tokens = actor.getActiveTokens();
     for (const t of tokens) {
-      await t.update({
+      await t.document.update({
         name: actor.name,
         img: clock.image.img,
         actorLink: true
Argonius-Angelus commented 2 years ago

Given this does seem thoroughly abandoned, I'd like to direct peeps to my version of the Clocks module called Lancer Clocks (name is just because it was designed to better conform to what Lancer wanted from clocks, and also it uses Lancer's clock styles). It's got a number of newer features and for the most part works with versions 0.7.9 and above. The ad-hoc Tiles are disabled as I have yet to figure out how to fix them for 0.8 and above (it's a lot more than just changing a couple of lines around).

https://github.com/Argonius-Angelus/lancer-clocks