troylelandshields / omgrpc

464 stars 25 forks source link

omgrpc does not support grpc validation rules #33

Open nickman opened 6 years ago

nickman commented 6 years ago

Trying to import an envoy proto. omgrpc reports:

Uh oh, something went wrong when importing that proto file... check the console and email me about it: Error: Parse error at line 39: illegal option name: (validate.rules).double.,

The issue is that it's choking on the validation syntax. Offending line looks like this:

// Identifies a percentage, in the range [0.0, 100.0].
message Percent {
  double value = 1 [(validate.rules).double = {gte: 0, lte: 100}];
}
troylelandshields commented 6 years ago

Dang... We need to update the grpc dependency, hopefully that will fix it. Thanks for pointing this out.