search

troystribling / BlueCap

iOS Bluetooth LE framework
MIT License
715 stars 115 forks source link

Bluetooth Restoration bug fix #68

Closed Soulphalanx closed 7 years ago

Soulphalanx commented 7 years ago

Fixes a case where Bluetooth restoration would fail if no scanning options were specified for that central. Setting the CentralManager's options property from the options in willRestoreState was removed because the options given in that method pertains to CBCentralManagerRestoredStateScanOptionsKey and not CBCentralManager options. The parameter names have been modified to reflect this.

troystribling commented 7 years ago

Thanks finding this bug. One of the test cases is failing. Could you fix it? To run the test cases run pod installin the Tests folder and open the generated workspace. Also, scanOptions could be removed from the interface. If this is done options could also be removed as a property but I will take care of that later.

Soulphalanx commented 7 years ago

I've updated the test and it's now passing. I've left scanOptions in the interface as there's still the restoration of a scan if the app was terminated while performing one. I don't have time right now, but I will probably eventually update it, especially if I end up needing it.

troystribling commented 7 years ago

Sounds good when tests pass will merge.

Soulphalanx commented 7 years ago

Weird, it doesn't seem to be building. There we go.