search

trpc-group / trpc-go

A pluggable, high-performance RPC framework written in golang
Other
743 stars 85 forks source link

gomod: upgrade golang.org/x/net to latest version #106

Closed WineChord closed 8 months ago

WineChord commented 8 months ago

https://github.com/trpc-group/trpc-go/security

codecov[bot] commented 8 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (dff87b7) 85.66% compared to head (4c8a0c4) 85.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #106 +/- ## ========================================== - Coverage 85.66% 85.63% -0.04% ========================================== Files 188 188 Lines 16114 16114 ========================================== - Hits 13804 13799 -5 - Misses 1747 1754 +7 + Partials 563 561 -2 ``` | [Flag](https://app.codecov.io/gh/trpc-group/trpc-go/pull/106/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trpc-group/trpc-go/pull/106/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | `85.63% <ø> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group#carryforward-flags-in-the-pull-request-comment) to find out more. [see 5 files with indirect coverage changes](https://app.codecov.io/gh/trpc-group/trpc-go/pull/106/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WineChord commented 8 months ago

Why has the code coverage decreased when I have only made changes to go.mod and go.sum files? 🙁

sandyskies commented 8 months ago

@WineChord check this https://app.codecov.io/gh/trpc-group/trpc-go/pull/106/indirect-changes

WineChord commented 8 months ago

I suspect that there might be a degree of randomization in the test cases, which could occasionally lead to variations in code coverage. For instance, in https://github.com/trpc-group/trpc-go/pull/113, despite only making changes to the markdown files, there was still a slight decrease in code coverage.