trpc-group / trpc-go

A pluggable, high-performance RPC framework written in golang
Other
743 stars 85 forks source link

Enable golangci check only on PR event #119

Closed Leoyoungxh closed 8 months ago

Leoyoungxh commented 8 months ago

golangci's only-new-issues option only takes effect during PR events, causing check failures when tagging. https://github.com/golangci/golangci-lint-action/blob/v3.7.0/README.md?plain=1#L63

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8528da7) 85.76393% compared to head (30f8bce) 85.63361%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #119 +/- ## =================================================== - Coverage 85.76393% 85.63361% -0.13032% =================================================== Files 188 188 Lines 16114 16114 =================================================== - Hits 13820 13799 -21 - Misses 1736 1754 +18 - Partials 558 561 +3 ``` | [Flag](https://app.codecov.io/gh/trpc-group/trpc-go/pull/119/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trpc-group/trpc-go/pull/119/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | `85.63361% <ø> (-0.13032%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group#carryforward-flags-in-the-pull-request-comment) to find out more. [see 6 files with indirect coverage changes](https://app.codecov.io/gh/trpc-group/trpc-go/pull/119/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.