search

trpc-group / trpc-go

A pluggable, high-performance RPC framework written in golang
Other
743 stars 85 forks source link

fix(example): update makefile #120

Closed lbbniu closed 8 months ago

lbbniu commented 8 months ago

not add option --noservicesuffix=false image

github-actions[bot] commented 8 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

lbbniu commented 8 months ago

I have read the CLA Document and I hereby sign the CLA

WineChord commented 8 months ago

I'm considering changing the default setting of noservicesuffix to false, aligning it with the internal version.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8528da7) 85.87564% compared to head (3fb75f5) 85.67705%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #120 +/- ## =================================================== - Coverage 85.87564% 85.67705% -0.19860% =================================================== Files 188 188 Lines 16114 16114 =================================================== - Hits 13838 13806 -32 - Misses 1722 1745 +23 - Partials 554 563 +9 ``` | [Flag](https://app.codecov.io/gh/trpc-group/trpc-go/pull/120/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trpc-group/trpc-go/pull/120/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | `85.67705% <ø> (-0.19860%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group#carryforward-flags-in-the-pull-request-comment) to find out more. [see 6 files with indirect coverage changes](https://app.codecov.io/gh/trpc-group/trpc-go/pull/120/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lbbniu commented 8 months ago

I'm considering changing the default setting of noservicesuffix to false, aligning it with the internal version.

[裂开]