search

trpc-group / trpc-go

A pluggable, high-performance RPC framework written in golang
Other
743 stars 85 forks source link

Use errors.New instead of fmt.Errorf #127

Closed chenyahui closed 8 months ago

chenyahui commented 8 months ago

I have read the CLA Document and I hereby sign the CLA

github-actions[bot] commented 8 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1536955) 85.54052% compared to head (a76e72a) 85.55294%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #127 +/- ## =================================================== + Coverage 85.54052% 85.55294% +0.01242% =================================================== Files 188 188 Lines 16114 16114 =================================================== + Hits 13784 13786 +2 + Misses 1771 1763 -8 - Partials 559 565 +6 ``` | [Flag](https://app.codecov.io/gh/trpc-group/trpc-go/pull/127/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trpc-group/trpc-go/pull/127/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | `85.55294% <0.00000%> (+0.01242%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/trpc-group/trpc-go/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | Coverage Δ | | |---|---|---| | [http/transport.go](https://app.codecov.io/gh/trpc-group/trpc-go/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group#diff-aHR0cC90cmFuc3BvcnQuZ28=) | `83.42697% <0.00000%> (ø)` | | | [log/log.go](https://app.codecov.io/gh/trpc-group/trpc-go/pull/127?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group#diff-bG9nL2xvZy5nbw==) | `89.93711% <0.00000%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/trpc-group/trpc-go/pull/127/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

liuzengh commented 8 months ago

I have read the CLA Document and I hereby sign the CLA

CLA check doesn't seem to be working properly. Could you post a new comment? @chenyahui

chenyahui commented 8 months ago

I have read the CLA Document and I hereby sign the CLA