codecov[bot]
commented
5 months ago Codecov Report
Attention: 11 lines in your changes are missing coverage. Please review.
Comparison is base (
65a60b1) 85.52917% compared to head (26b9e07) 85.60010%.
| Files | Patch % | Lines |
|---|---|---|
| restful/serialize_jsonpb.go | 46.15385% | 6 Missing and 1 partial :warning: |
| codec/serialization_json.go | 0.00000% | 4 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #159 +/- ## =================================================== + Coverage 85.52917% 85.60010% +0.07093% =================================================== Files 189 189 Lines 16129 16139 +10 =================================================== + Hits 13795 13815 +20 + Misses 1774 1762 -12 - Partials 560 562 +2 ``` | [Flag](https://app.codecov.io/gh/trpc-group/trpc-go/pull/159/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trpc-group/trpc-go/pull/159/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | `85.60010% <35.29412%> (+0.07093%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Andrew-M-C
As an alternative of #157, not removing json-iterator, but allow user to override default JSON serializer.