trpc-group / trpc-go

A pluggable, high-performance RPC framework written in golang
Other
742 stars 85 forks source link

docs: add comments informing that global variable JSONAPI should not be modified (#157) #160

Closed Andrew-M-C closed 5 months ago

Andrew-M-C commented 5 months ago

docs: add comments informing that global variable JSONAPI should not be modified (#157)

Discussions took place in #157

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (65a60b1) 85.52917% compared to head (c15d95a) 85.64697%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #160 +/- ## =================================================== + Coverage 85.52917% 85.64697% +0.11780% =================================================== Files 189 189 Lines 16129 16129 =================================================== + Hits 13795 13814 +19 + Misses 1774 1753 -21 - Partials 560 562 +2 ``` | [Flag](https://app.codecov.io/gh/trpc-group/trpc-go/pull/160/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/trpc-group/trpc-go/pull/160/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group) | `85.64697% <ø> (+0.11780%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=trpc-group#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Andrew-M-C commented 5 months ago

Changed the position of Deprecated: for lint in CI